Parameter substitution needs to be limited

[HolQue]

Somewhere in the past it has been decided to allow the substitution of dollar operator expressions within strings only for parameters of data type 'str' and 'int' (not others like 'dict' and 'list' any more). And on both the left hand side of the colon and the right hand side of the colon.

The following combinations are blocked correctly (like expected):

"dictParam"    : {"A" : 0, "B" : 1},
"${dictParam}" : 1

"listParam"    : ["A", "B"],
"${listParam}" : 1

But the following combinations are not blocked. The substitution work, but should be blocked now also:

"dictParam"  : {"A" : 0, "B" : 1},
"param"      : "${dictParam}"

"listParam"  : ["A", "B"],
"param"      : "${listParam}"

How about float values:

"floatParam" : 1.2,
"param"      : "${floatParam}"

"floatParam"    : 1.2,
"${floatParam}" : 1

Currently substitution work. Keep working or block it?

[namsonx]

Hello Holger,

Thomas decided to block the Parameter substitution via ticket #270
I implemented and pushed the change to stabi branch.

Thank you,
Son

[HolQue]

Hi Son,

in expressions on the right hand side of the colon still composite data types are not blocked inside strings.

I tried:

"strval"    : "ABC",
"intval"    : 1,
"floatval"  : 2.3,
"boolval"   : True,
"noneval"   : None,
"listval"   : [1,2,3],
"dictval"   : {"A" : "B"},
"newparam1" : "prefix_${strval}_suffix",
"newparam2" : "prefix_${intval}_suffix",
"newparam3" : "prefix_${floatval}_suffix",
"newparam4" : "prefix_${boolval}_suffix",
"newparam5" : "prefix_${noneval}_suffix",
"newparam6" : "prefix_${listval}_suffix",
"newparam7" : "prefix_${dictval}_suffix"

With result:

{'boolval': True,
 'dictval': {'A': 'B'},
 'floatval': 2.3,
 'intval': 1,
 'listval': [1, 2, 3],
 'newparam1': 'prefix_ABC_suffix',
 'newparam2': 'prefix_1_suffix',
 'newparam3': 'prefix_2.3_suffix',
 'newparam4': 'prefix_True_suffix',
 'newparam5': 'prefix_None_suffix',
 'newparam6': 'prefix_[1, 2, 3]_suffix',
 'newparam7': "prefix_{'A': 'B'}_suffix",
 'noneval': None,
 'strval': 'ABC'}

In case of newparam6 and newparam7 I would expect an error message telling that the substitution of nested data types inside string values is not supported.

[namsonx]

Hello Holger,

The value on the right-hand side of the colon, if enclosed in double quotes, is converted to the string datatype following Python's behavior. Additionally, users can convert dictionaries or lists to strings for specific purposes, as allowed by JP.

From my point of view, we should allow users convert event dictionaries, lists, ... to string if they want to do it.
Hello @test-fullautomation, could you please give us your opinion?

Thank you,
Son

[namsonx]

We will implement like Holger's expectation