Side effects of latest changes (2)

[HolQue]

Latest changes in JsonPreprocessor have side effects.

(1)

"newparam" : ${indexP.${indexP}}

An integer cannot be applied to an integer.

Previous error message:

'Invalid expression found: '${indexP.${indexP}}'.'

New error message:

'The variable '${indexP}[0]' is not available!'

This is a deterioration. The previous error message was fine.

In pure Python

index = 2
param = index[index]

This would cause a

TypeError: 'int' object is not subscriptable

This would also be OK.

But telling that a variable does not exist, is misleading. There is no variable missing. This is a type issue. In case you rework something, you already can consider:
#257 (comment)
It has already been decided not to use the term "variable" any more. Use "parameter" instead.

(2)

Same with a string applied to an integer

"newparam" : ${indexP.${keyP}}

Previous error message:

'Invalid expression found: '${indexP.${keyP}}'.'

New error message:

'The variable '${indexP}['A']' is not available!'

Also in this case Python would throw:

TypeError: 'int' object is not subscriptable

Therefore same issue like in (1):

Telling that a variable does not exist, is misleading. There is no variable missing. This is a type issue. In case you rework something, you already can consider:
#257 (comment)
It has already been decided not to use the term "variable" any more. Use "parameter" instead.

(3)

Also a dictionary cannot be applied to an integer.

"newparam" : ${indexP.${dictP}}

Previous error message:

'Invalid expression found: '${indexP.${dictP}}'.'

New error message:

''NoneType' object is not subscriptable'

Same issue like in (1) and (2).

This error message is not helpful. Please restore the previous one or take over the error message from Python (TypeError: 'int' object is not subscriptable).

Same with

"newparam" : ${indexP.${listP}}

(4)

A string cannot be applied to a string.

"newparam" : ${keyP.${keyP}}

Previous error message:

'Invalid expression found: '${keyP.${keyP}}'.'

New error message:

'The variable '${keyP}['A']' is not available!'

Same issue like before: There is no variable missing. This is a type issue. This expression ${keyP.${keyP}} is simply an invalid combination of data types.

In such a case Python would throw:

TypeError: string indices must be integers

Please take over the error message from Python.

In general:

I already mentioned this several times: In case of expressions like ${X}[Y] you urgently have to consider the data type of X and Y.

When you implement changes you also should check impacts and side effects of your changes. This would avoid the need to spend time on writing and tracking issues like this.

You should try to get a better overview about your code and align the implementation. Often things work well, but not everywhere in the same way.

For example:

"${keyP}['${indexP}']" : "newvalue"

This error (string by mistake used as index) is already detected properly:

'${keyP} expects integer as index. Got string instead in ${keyP}['${indexP}']'

This corresponds to (4):

"newparam" : ${keyP.${keyP}}

Therefore I expect the same error message.

[namsonx]

Hello Holger,

This ticket was implemented on stabi branch.

Thank you,
Son

[HolQue]

(1), (2) and (4) solved.
(3) still open.

[namsonx]

Hello Holger,

I had updated error message log for case (3), the error message of this case looks like below:

Exception: Could not resolved the expression ${indexP.${dictP}}. The datatype of ${dictP} must be 'str' or 'int' not 'dict'.

Thank you,
Son

[HolQue]

Hi Son,

what are you doing? This error message is wrong! An 'int' object is not subscriptable. In (3) I already wrote what is expected.

[namsonx]

Hello Holger,

In case (3) "newparam" : ${indexP.${dictP}}, there are 2 causes of error I can observe:

• First : Like your expectation Reason: 'int' object is not subscriptable
• Second: Could not resolve the sub-element .${dictP} because the datatype of ${dictP} is 'dict'
  I just tried to approach with the second option because it's more simple to implement.

Anyway, I had implemented the first option as you expected and push the commit to the stabi branch. Now, the error message is Exception: Could not resolved the expression '${indexP.${dictP}}'. Reason: 'int' object is not subscriptable

Thank you,