[ 2374946 ] Error messages (26)

[HolQue]

Previously this code

{
   "index"     : 1,
   "indexList" : [0,1,2],
   "param2"    : "${indexList}[${indexList}[[${index}]]"
}

caused

'Invalid expression found: '${indexList}[${indexList}[[${index}]]'.'

That is completely fine. The expression contains an additional opened square bracket. No chance to detect the meaning of this.
Therefore the expression is simply "invalid".

With latest changes of the JsonPreprocessor the error message changed to:

'Invalid parameter format: $${indexList}[$${indexList}[[1]] - The double quotes are missing!!!'

This is misleading and wrong. The error message contains double '$$' and there are no double quotes missing.

Or in other words: Out of this invalid expression it cannot be concluded that double quotes are missing.

The previous error message should be restored.

[namsonx]

Hello Holger,

I fixed and pushed the change to stabi branch.

Thank you,
Son

[HolQue]

Retest successful. Issue can be closed.

[HolQue]

Hi Son,

the issue is back. Most probably caused by fix of

#347

(because not seen in RobotFramework_AIO_setup_0.13.1.15_extended.exe).

[namsonx]

Hello Holger,

This ticket is back due to I updated the pattern of regex regarding to the suggestion from code scanning https://github.com/test-fullautomation/python-jsonpreprocessor/security/code-scanning

I changed it back via a commit 3d1c159d660

Thank you,
Son

[HolQue]

Hi Son,

OK, but what does this mean? Is it not possible now to solve the code scanning issue or do you plan to work on an alternative solution?

[namsonx]

Hello Holger,

Code scanning just gives a warning not an issue regarding to the regex pattern, in this case I define the pattern:

if re.match(r'^\${[^}]+}+(\[.+\])*\s*$', sInput)

and Code scanning gives the warning about \[.+\] that This part of the regular expression may cause exponential backtracking on strings starting with '$${a}[' and containing many repetitions of ']['.

In the case we have nested parameters inside the nested parameter, then there are many repetitions of ']['.
This case I already mentioned to Thomas in our meeting.

Thank you,
Son

[HolQue]

Hi Son,

this does not answer my question.