-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
Hi Son,
regarding:
def __loadAndRemoveComments(self, jsonP : str, isFile = True) -> str:
The name of this method is misleading. It looks like that also the comments are loaded. But that is not what the method does.
Loading content from a file and computing the content are two completely different things, and therefore should not be done in one single method.
Content can also be provided by jsonLoads. Here a file is not involved. And it is strange to have the need to use an additional parameter like isFile to control the behavior.
Please make a split of this method, something like:
__loadFromFile__removeComments
Metadata
Metadata
Assignees
Projects
Status
In Progress