[ 2374917 ] Error messages (48)

[HolQue]

JSONP:

{
   "indexP" : 0,
   "keyP"   : "A",
   "dictP"  : {"A" : 0, "B" : 1},
   "listP"  : ["A", "B"],

   "params" : {"001" : "002",
               "003" : ["004", {"005" : "006",
                              "007" : ["008", ["009", "010"]],
                              ${keyP : ["012", {"013" : "014"}],
                              "015" : {"016" : ["017", "018"]},
                              "019" : {"020" : {"021" : "022"}}
                             }
                       ]
              }
}

Error message:

'Invalid key name: 'keyP : ["012", {"013" : "014"' in ${keyP : ["012", {"013" : "014"}. Key names are limited to letters, digits and the following characters: _ + - * /'

But the issue is not an invalid key name, it's a missing closed curly bracket.

I would prefer to have a "brackets mismatch" error message.

[HolQue]

Hmm, maybe a difficult thing. This is related to the order the different error detection mechanisms are executed within the JsonPreprocessor. I have the following in my mind: Before you check a key name against a naming convention you need to identify the name. This requires a corresponding closing curly bracket for every opening curly bracket (together with the dollar operator). In case of a closing bracket is missing, you cannot identify the name. Because you do not know where the name ends. This is a syntax error. In this case a statement about the validity of the key name makes no sense (and is also misleading for users).

But there is a closing curly bracket, but this belongs to an inline dictionary: {"013" : "014"}. Is it possible to detect this?

[HolQue]

Hi Son,

another idea. This is the critical line:

${keyP : ["012", {"013" : "014"}]

While scanning characters after ${, a colon is detected (before a closing curly bracket is detected).

We have two possibilities to react on that:

We assume we are still inside a key name, and we throw a naming convention error because of a colon is not allowed inside key names. This is how it is realized currently.

Or we interprete a colon as part of the JSON syntax with highest priority. We assume that a colon can never be a part of a key name. This rule would strongly require a closing curly bracket before the first colon in the example above. Because this bracket is missing, it is possible to detect a syntax error (instead of a naming convention violation).

What do you think?

[namsonx]

Hello Holger,

Thank you for the hint! I updated and push the change to the stabi branch.

Thank you,
Son