[ 2440282 ] Empty key names

[HolQue]

Some issues ago I proposed to handle key names containing blanks only, as empty names (that are not allowed). This still makes sense for me and is implemented properly.

But with the new 'keyPattern' parameter I can do this:

json_preprocessor = CJsonPreprocessor(keyPattern = " ")

and

" " : 2

Result:

Error: 'Error: Key name '' is invalid. Expected format: ' ''!

All is implemented like discussed, but nevertheless this result looks a bit strange.

I propose to make sure that the handling of blanks is aligned in the regular expressions and in key names.

I see two possibilities to handle this:

(1)

Similar to #424 we can handle

keyPattern = " "

as not supported and raise an exception.

(2)

The JsonPreprocessor must not execute a strip() on key names any more. But I have doubts that it makes sense to allow key names like " ".

Seems that we need a naming convention for user defined naming conventions.

[namsonx]

Hello Holger,

Regarding the point (1), I agree with you that we will implement similar to #424.

For the point (2), in case we remove strip() on key names, the below cases:

"keyname  "   : "value"
"  keyname"   : "value"
"  keyname  " : "value"

These cases will be generated 3 different parameters.

Thank you,
Son

[HolQue]

Hi Son,

you're right. Maybe my wording was mistakable. What I wanted to say is: either (1) or (2). And like you I would prefer (1).

Key patterns like

keyPattern = " " (any number of spaces)

or

keyPattern = ".*"

should raise an exception.

[namsonx]

Hello Holger,

I pushed the change to stabi branch, can you check and give your feedback if any. The error message in this case now is:

Exception: The key pattern '   ' just allows a key name that contains only whitespace!

Thank you,
Son

[HolQue]

Retest successful. Issue can be closed.