Add additional syntax precheck. #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namsonx
requested review from
HolQue,
huavanthong,
milanac030988,
ngoan1608,
test-fullautomation and
trimai3001
HolQue
reviewed
Aug 2, 2023
| try: | ||
| listDummy = shlex.split(line) | ||
| except Exception as error: | ||
| raise Exception(f"\n[shlex exception]\n {str(error)} \nin line: '{line}'") |
Collaborator
There was a problem hiding this comment.
Hi Son,
the error message part "[shlex exception]" was only intended to be an example in my Python example code. No need to take over this in the code of the JsonPreprocessor. No need to tell the users the name of the parser who causes the error message. Please remove "[shlex exception]" ;-)
Collaborator
Author
There was a problem hiding this comment.
Hello Holger,
Thank you, I will update!
Thank you,
Son
HolQue
reviewed
Aug 2, 2023
Collaborator
HolQue
left a comment
HolQue
left a comment
There was a problem hiding this comment.
Only tiny modification wanted ;-)
Collaborator
|
But nevertheless. The error detection works! |
Collaborator
Author
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.