Skip to content

Conversation

@test-fullautomation
Copy link
Owner

No description provided.

@test-fullautomation
Copy link
Owner Author

Hi Son,
can you please review and test this changes with testsuites-management?

  • I stabilized path functions. It was e.g. not possible to use relative paths when used by a python module (I created sample.py for this).
  • I optimized the code for "remove_comments". Also /* */ multiline-comments are working now.
  • I added a start for python samples.
    Thank you,
    Thomas

@namsonx
Copy link
Collaborator

namsonx commented Mar 17, 2022

Hello Thomas,

 I will test with testsuites-management package and inform you the result.

Thank you,
Son

@test-fullautomation
Copy link
Owner Author

test-fullautomation commented Mar 17, 2022

Hi Son,
thank you, but we need to talk before.
I assume that it will be not compatible to testsuites-management now. The atest is also not working anymore.
I have to explain why and we need to find the further strategy.
Thank you,
Thomas

sample/sample.py Outdated

prepro=JsonPreprocessor.CJsonPreprocessor()

data=prepro.jsonLoad(".\json\json_with_comment.json")
Copy link
Owner Author

@test-fullautomation test-fullautomation Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
important is that this use-case is working.
We assume that most of the users will not require this for robotframework, but for any other python project.
Usually in this case the configuration data is either relative to the project, or refrerenced by means of an environment variable.
Thank you,
Thomas

sContent=file.read()
file.close()

pattern = re.compile(r'//.*?$|/\*.*?\*/|\'(?:\\.|[^\\\'])*\'|"(?:\\.|[^\\"])*"', re.DOTALL | re.MULTILINE)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows /* */ multiline comments, too.

ThPoll added 3 commits March 18, 2022 16:47
- add annotations to functions
- absolute and relative paths are allowed for main file as well as [import] file.
- %envvariable% and {envvariable} syntax are allowed in paths
- [import] is now relative to the current file, instead of relative to the base file. This allows shorter paths and it allows to move whole sets of json files to other locations. Only the path to root file of a subset need to be changed in this case.
- all docstrings are now in rst syntax and maintained
- lot of documenation added
- f syntax is use for all exception strings.
- unified style of all exception strings.
@test-fullautomation
Copy link
Owner Author

Must be tested and then merged together with
test-fullautomation/robotframework-testsuitesmanagement#19

@test-fullautomation test-fullautomation added enhancement New feature or request 0.5.2 labels Jun 21, 2022
@test-fullautomation test-fullautomation added this to the 0.5.2.0 Win10 milestone Jun 21, 2022
@test-fullautomation test-fullautomation merged commit 6c153b1 into develop Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.5.2 enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants