Improve overwrite parameter methodology #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues Caution: Self test does not run until the issues are not solved! test-fullautomation/robotframework-testsuitesmanagement#223 test-fullautomation/robotframework-testsuitesmanagement#224 test-fullautomation/robotframework-testsuitesmanagement#225
namsonx
requested review from
HolQue,
huavanthong,
milanac030988,
ngoan1608,
test-fullautomation and
trimai3001
…_and_documentation_extensions Added self test cases JPP_0507, JPP_0508, JPP_0509
HolQue
reviewed
Oct 5, 2023
Collaborator
HolQue
left a comment
HolQue
left a comment
There was a problem hiding this comment.
JPP_0508 successful now!
JPP_0507 and JPP_0509 fail.
test-fullautomation
requested changes
Oct 5, 2023
Owner
There was a problem hiding this comment.
Hi Son,
thank you for your pull-request.
Can you please replace hardcoded strings like "__handleDuplicatedKey__" or "__RecursiveInitialValue__" with enums.
Using strings is very error prone.
Enums: https://docs.python.org/3/howto/enum.html
Thank you,
Thomas
Caution: Self test does not run until the issues are not solved!
…_and_documentation_extensions Extended self test JPP_1000; added self test JPP_1001
* Replaced '-' by '_' in alls tests * Activated test case JPP_0205 (successful now)
…_and_documentation_extensions Maintenance
test-fullautomation
approved these changes
Oct 10, 2023
Owner
test-fullautomation
left a comment
test-fullautomation
left a comment
There was a problem hiding this comment.
Hi Son,
looks good to me!
Thank you,
Thomas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.