Skip to content

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Sep 13, 2022

No description provided.

@HolQue
Copy link
Collaborator

HolQue commented Sep 13, 2022

Handling of
"string_val" : "${not_existing}",
"string_val" : "test string",
works now!

But spelling and wording of error message :
"Unknown exception occurs. Details: Loading of The variable 'not_existing' is not available!"
should be reworked. See proposal in ticket description:
"Unknown exception occurs. Details: The variable 'not_existing' is not available!"

Because of the changes: the version number, the version date and the history should be updated.

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling of
"string_val" : "${not_existing}",
"string_val" : "test string",
works now!

But spelling and wording of error message :
"Unknown exception occurs. Details: Loading of The variable 'not_existing' is not available!"
should be reworked. See proposal in ticket description:
"Unknown exception occurs. Details: The variable 'not_existing' is not available!"

Because of the changes: the version number, the version date and the history should be updated.

@namsonx
Copy link
Collaborator Author

namsonx commented Sep 14, 2022

Sure I will update the error message and the version of python-jsonpreprocessor package also

@namsonx
Copy link
Collaborator Author

namsonx commented Sep 14, 2022

Hello @HolQue ,

"Unknown exception occurs. Details: Loading of The variable 'not_existing' is not available!"
should be reworked. See proposal in ticket description:
"Unknown exception occurs. Details: The variable 'not_existing' is not available!"

I have just checked, this wording issue will be fixed in Testsuites-Management package.

Thank you,
Son

@test-fullautomation
Copy link
Owner

test-fullautomation commented Sep 14, 2022

Hi Son,
I don't understand

I have just checked, this wording issue will be fixed in Testsuites-Management package.

json-preprocessor can run also without testsuites-management. Therefore messages of json-preprocessor must be correct.

json-preprocessor need to raise:
"Unknown exception occurs. Details: The variable 'not_existing' is not available!"

Thank you,
Thomas

@namsonx
Copy link
Collaborator Author

namsonx commented Sep 14, 2022

Hello Thomas,

In testsuites-management package, I call jsonload() of jsonpreprocessor package in try: ... Exception: . And in this Exception, I added some more words in error log together with error log of jsonload()
That the reason we have this wording issue in ROBFW-AIO.

Thank you,
Son

@test-fullautomation
Copy link
Owner

Hi Son,
O.K. very good I got it.
Best is always not to add anything to catched exceptions. The exception message itself should contain all required information.
Thank you,
Thomas

Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
I will merge the change.
Thanky you,
Thomas

@test-fullautomation test-fullautomation merged commit 28d35b6 into test-fullautomation:develop Sep 27, 2022
@namsonx
Copy link
Collaborator Author

namsonx commented Sep 27, 2022

Hello Thomas,

Sure, this change work fine.
I implemented and have been testing the enhancement features which we discussed last sync up meeting.
I will create another pull-request tomorrow.

Thank you,
Son

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants