-
Notifications
You must be signed in to change notification settings - Fork 2
Improve syntax of Json configuration file of ROBFW-AIO #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve syntax of Json configuration file of ROBFW-AIO #22
Conversation
|
Hi Son, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the key value is of type string it makes no difference if the complete expression is encapsulated in quotes or not:
(1) "${params}['global']['string_val']"
(2) ${params}['global']['string_val']
This is OK, but the user should be aware of that - therefore this should be mentioned anywhere in the documentation, maybe as recommendation that the quotes are not necessary in this case.
Keys of type int, float and bool are recognized correctly (when expression is without quotes). With quotes the values are of type string correctly.
Keys that are None or null are also recognized correctly (but independently from quotes around the expression).
Also with quotes ("${params}['global']['null_val']") the value is of type NoneType. But in my opinion it would be more consistent when with quotes the type would be string.
|
Hi Holger, |
|
Hello Thomas, Thank you, |
|
Hi Son, |
|
Hello Thomas, Thank you, |
|
Hi Son, |
|
Hi Son, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Son,
look O.K. for me.
Let us test. I will do further maintenance of the documentation.
Thank you,
Thomas
| -------------- | ||
|
|
||
| .. image:: ./pictures/python3-jsonpreprocessor.png | ||
| Firstly, clone `python-jsonpreprocessor <https://github.com/test-fullautomation/python-jsonpreprocessor>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Son,
pease refer to genpackagedoc. I sent some weeks ago a mail that genpackagedoc shall be the reference.
first we propose pip install.
Please make this document similar.
Thank you,
Thomas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Son,
I will maintain this.
Thank you,
Thomas
No description provided.