Skip to content

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Apr 8, 2024

No description provided.

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,

you improved a little bit too much. Even in case of a dictionary

"newparam" : ${dictP}['${indexP}']

the new error message is:

'The ${dictP} expects integer as index. Got string instead in the ${dictP}['${indexP}']'

But that's wrong. Dictionaries have keys, and keys can be both strings and integers.

And please adapt your choice of words:

Not: "in the ..."
But: "in expression ..."
Or much shorter: "in ..."

@namsonx
Copy link
Collaborator Author

namsonx commented Apr 8, 2024

Hi Son,

you improved a little bit too much. Even in case of a dictionary

"newparam" : ${dictP}['${indexP}']

the new error message is:

'The ${dictP} expects integer as index. Got string instead in the ${dictP}['${indexP}']'

But that's wrong. Dictionaries have keys, and keys can be both strings and integers.

And please adapt your choice of words:

Not: "in the ..." But: "in expression ..." Or much shorter: "in ..."

Hello Holger,

Thank you for your correction! I updated the error message.

Thank you.

@test-fullautomation test-fullautomation added enhancement New feature or request 0.11.0 labels Apr 8, 2024
@test-fullautomation test-fullautomation added this to the 0.11.0 milestone Apr 8, 2024
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
looks good to me!
Thank you,
Thomas

@test-fullautomation test-fullautomation merged commit 84359cf into develop Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.11.0 enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

4 participants