Skip to content

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Dec 2, 2022

Hello Thomas,

 I created this small change for the corner case below during implementing selftest:   
${preprocessor}['definitions']['preproStructure'][${params}['glo']['globalStructure']['general']]: 0.92

 For now both cases below are working:
       - "${preprocessor}['definitions']['preproStructure'][${params}['glo']['globalStructure']['general']]": 0.92
       - ${preprocessor}['definitions']['preproStructure'][${params}['glo']['globalStructure']['general']]: 0.92

Thank you,
Son

@HolQue
Copy link
Collaborator

HolQue commented Dec 2, 2022

Hello Son,
thank you very much for this clarification! Yesterday I stumbled about this. But when it completely doesn't matter if we put dollar operator statements on the left side of the colon in quotes or not, we should give a strict recommendation to all users about which style to follow. And we should make sure to do it consequently also in all documents we provide.

What shall be the recommendation? With or without quotes?

I will explain this topic later in the test suites tutorial.

@namsonx
Copy link
Collaborator Author

namsonx commented Dec 2, 2022

Hello Holger,

 To align with what we improved for the right side of the colon, I personally recommend that we should not use quotes for the left side of the colon also.
 But for now, both ways (with or without quotes in the right side of colon) are acceptable, the reason behind is I don't want the current users of ROBFW-AIO have to rework on their json configuration files :)

Thank you,
Son

@HolQue
Copy link
Collaborator

HolQue commented Dec 2, 2022

Hello Son,
I agree to your recommendation.

@HolQue
Copy link
Collaborator

HolQue commented Dec 2, 2022

Hello Son,

only to verify that I have understood the feature now:

There is no syntactical difference between
${params}['global']['param'] : 123
and
"${params}['global']['param']" : 123
In both cases param is of type int.

"param1" : 123
"param2" : "123"
param1 is of type int; param2 is of type str.

"param4" : ${params}['global']['param1']
"param5" : ${params}['global']['param2']
param4 is of type int; param5 is of type str.

"param6" : "${params}['global']['param1']"
param6 is of type str!

"param7" : "${params}['global']['param2']"
param7 is of type str. The quotes around ${params}['global']['param2'] do not matter because param2 is already of type str.

Is this correct?

@namsonx
Copy link
Collaborator Author

namsonx commented Dec 2, 2022

Hello Son,

only to verify that I have understood the feature now:

There is no syntactical difference between

${params}['global']['param'] : 123
and
"${params}['global']['param']" : 123
In both cases param is of type int.

"param1" : 123

"param2" : "123"
param1 is of type int; param2 is of type str.

"param4" : ${params}['global']['param1']

"param5" : ${params}['global']['param2']
param4 is of type int; param5 is of type str.

"param6" : "${params}['global']['param1']"

param6 is of type str!
"param7" : "${params}['global']['param2']" param7 is of type str. The quotes around ${params}['global']['param2'] do not matter because param2 is already of type str.

Is this correct?

Hi Holger,

Yes, it is correct!

Thank you,
Son

@HolQue
Copy link
Collaborator

HolQue commented Dec 2, 2022

You made my day! ;-)

Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
looks good to me!
Thank you,
Thomas

@test-fullautomation test-fullautomation merged commit 8650dcc into develop Dec 2, 2022
@test-fullautomation test-fullautomation added 0.6.0 enhancement New feature or request labels Dec 2, 2022
@test-fullautomation test-fullautomation added this to the 0.6.0.0 Win10 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.6.0 enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants