Skip to content

Fix issue34 - absolute paths in sample #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix issue34 - absolute paths in sample #42

merged 1 commit into from
Jan 10, 2023

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Jan 10, 2023

No description provided.

@namsonx namsonx mentioned this pull request Jan 10, 2023
Closed
@test-fullautomation test-fullautomation added enhancement New feature or request 0.6.0 labels Jan 10, 2023
@test-fullautomation test-fullautomation added this to the 0.6.0.0 Win10 milestone Jan 10, 2023
test-fullautomation
test-fullautomation approved these changes Jan 10, 2023
View reviewed changes
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
looks good me!
Might be that in addition normalizing would be better. Can be a problem with Windows or UNC paths.
Merged nevertheless. Please check UNC paths like \\hi-z.abc.de......
Thank you,
Thomas

@test-fullautomation test-fullautomation merged commit 1887c7e into develop Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@test-fullautomation test-fullautomation test-fullautomation approved these changes

@milanac030988 milanac030988 Awaiting requested review from milanac030988

@ngoan1608 ngoan1608 Awaiting requested review from ngoan1608

@tranhoangnguyen193 tranhoangnguyen193 Awaiting requested review from tranhoangnguyen193

@HolQue HolQue Awaiting requested review from HolQue

Assignees

No one assigned

Labels

0.6.0 enhancement New feature or request

Projects

RobotFramework AIO
Archived in project

Milestone

0.6.0.0 Win10

Development

Successfully merging this pull request may close these issues.

3 participants

@namsonx @test-fullautomation