Skip to content

Adds selftest for utf-8 encoding. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 17, 2023
Merged

Adds selftest for utf-8 encoding. #44

merged 19 commits into from
Feb 17, 2023

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Jan 11, 2023

No description provided.

@test-fullautomation test-fullautomation added enhancement New feature or request 0.6.0 labels Jan 11, 2023
@test-fullautomation test-fullautomation added this to the 0.6.0.0 Win10 milestone Jan 11, 2023
@test-fullautomation test-fullautomation added selftest and removed enhancement New feature or request labels Jan 11, 2023
@test-fullautomation
Copy link
Owner

test-fullautomation commented Jan 11, 2023

Hi Son,
very good!
Please add five tests:

  1. import into utf-8 file "normal" data
  2. import into utf-8 file another utf-8 file
  3. import into "normal" file utf-8 file
  4. create parameter where key and value have utf-8 data. Overwrite other existing value with ${utf-8 key}
  5. like 4, but nested

Thank you,
Thomas

test-fullautomation

This comment was marked as duplicate.

Sign in to view

test-fullautomation
test-fullautomation requested changes Jan 13, 2023
View reviewed changes
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
please check my findings.
Thank you,
Thomas

@test-fullautomation
Copy link
Owner

test-fullautomation commented Jan 23, 2023

Hi Son,
please provide the requested additional tests.
Thank you,
Thomas

HolQue and others added 13 commits February 6, 2023 15:43
@HolQue @namsonx
Added executerobottest.py to support the TestTrigger
733e893
@HolQue @namsonx
Replaced executerobottest.py by executepytest.py (because of planned …
89ac8ae 
…rework of the atest)
@HolQue @namsonx
tiny fixes
41708dd
@ngoan1608 @namsonx
rename test file so that pytest can collect it for execution
f855691
@ngoan1608 @namsonx
ignore build stuff and logfiles
33a0826
@HolQue @namsonx
Removed PythonExtensionsCollection
aa29cd2 
(because is already part of the install dependencies)
@namsonx
Revert "Removed PythonExtensionsCollection"
466f476 
This reverts commit aa29cd2.
@namsonx
Revert "ignore build stuff and logfiles"
fe0b0ba 
This reverts commit 33a0826.
@namsonx
Revert "rename test file so that pytest can collect it for execution"
77bf8c9 
This reverts commit f855691.
@namsonx
Revert "tiny fixes"
e7fb189 
This reverts commit 41708dd.
@namsonx
Revert "Replaced executerobottest.py by executepytest.py (because of …
bf92c6e 
…planned rework of the atest)"

This reverts commit 89ac8ae.
@namsonx
Revert "Added executerobottest.py to support the TestTrigger"
085cf1f 
This reverts commit 733e893.
@namsonx
Add more unittest cases for utf8 format.
32ae51e
@namsonx
Copy link
Collaborator Author

namsonx commented Feb 6, 2023

Hello Thomas,

I have just added more unittest cases for utf-8 handling.

Thank you

test-fullautomation
test-fullautomation approved these changes Feb 8, 2023
View reviewed changes
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,

looks good to me!

Thank you,
Thomas

@test-fullautomation
Copy link
Owner

test-fullautomation commented Feb 8, 2023

Hi Son,
there is a merge conflict in atest/jsonpreprocessor/jsonpreprocessor_unittest.py
Please solve this.
Thank you,
Thomas

test-fullautomation
test-fullautomation requested changes Feb 15, 2023
View reviewed changes
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
unfortunately I can still not merge due to merge conflicts.
Please solve this as soon as possible.
Thank you,
Thomas

@namsonx
Copy link
Collaborator Author

namsonx commented Feb 15, 2023

Hello Thomas,

I have just resolved conflict of this pull-request.

Thank you,
Son

test-fullautomation
test-fullautomation approved these changes Feb 16, 2023
View reviewed changes
Copy link
Owner

@test-fullautomation test-fullautomation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
uups. sorry, I have still conflicts here with test_jsonpreprocessor.py.
Thank you,
Thomas

test-fullautomation
test-fullautomation requested changes Feb 16, 2023
View reviewed changes
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
I have unfortunately still merge confilcts.
Please solve this.
Thank you,
Thomas

@namsonx
Copy link
Collaborator Author

namsonx commented Feb 16, 2023

Hello Thomas,

I have just resolved the merge conflict, you can merge it now :)

Thank you,
Son

@test-fullautomation test-fullautomation merged commit ca53165 into develop Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@test-fullautomation test-fullautomation test-fullautomation approved these changes

@milanac030988 milanac030988 Awaiting requested review from milanac030988

@ngoan1608 ngoan1608 Awaiting requested review from ngoan1608

@tranhoangnguyen193 tranhoangnguyen193 Awaiting requested review from tranhoangnguyen193

@HolQue HolQue Awaiting requested review from HolQue

Assignees

@namsonx namsonx

Labels

0.7.0 selftest

Projects

RobotFramework AIO
Archived in project

Milestone

0.6.0.0 Win10

Development

Successfully merging this pull request may close these issues.

5 participants

@namsonx @test-fullautomation @HolQue @ngoan1608