BADCASE tests of section INLINE_CODE added #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tests are commented out * Expected results not yet defined Reason: Feature currently under construction
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for Python inline code in the JSON Preprocessor (JPP) by introducing new BADCASE tests for the INLINE_CODE section. The tests are currently commented out as the feature is still under construction.
- Adds 42 new test cases (JPP_2150-JPP_2191) covering various edge cases and error conditions for Python inline code
- Updates code generation tools to include better bracket handling and inline code test generation
- Minor updates to existing test files and version information
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/testtools/GenSnippetsJPP.py | Major update adding inline code test generation, improved bracket handling methods, and version bump |
| test/testconfig/TestConfig.py | Adds 42 new commented-out test case definitions for inline code BADCASE scenarios |
| test/testfiles/jpp-test_config_*.jsonp | 42 new test files containing various inline code error scenarios |
| test/component_test.py | Minor version update from 0.62.0 to 0.63.0 |
Comments suppressed due to low confidence (2)
test/testtools/GenSnippetsJPP.py:3544
- The closing angle bracket is missing in the Python inline code. It should be "<<("A" if True else "B")>>" : 1 to properly close the inline code block.
"<<(\"A\" if True else \"B\">>" : 1
test/testtools/GenSnippetsJPP.py:4460
- There's a spelling error in the comment. "BADGASE" should be "BADCASE".
for sPlaceholder in listPlaceholders:
| listCodeSnippets.append("""{ | ||
| // "JPP_2167" | ||
| // Python inline code as dictionary key at left hand side of the colon | ||
| "A" : {"B" : 1, "C" . 2}, |
There was a problem hiding this comment.
There's a syntax error in the JSON structure. The colon ":" should be used instead of a dot "." to separate the key-value pair. It should be "C" : 2.
Suggested change
| "A" : {"B" : 1, "C" . 2}, | |
| "A" : {"B" : 1, "C" : 2}, |
There was a problem hiding this comment.
The errors are part of BADCASE tests and are therefore intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: Feature currently under construction