Skip to content

Conversation

@HolQue
Copy link
Collaborator

@HolQue HolQue commented Aug 11, 2025

Little typo in CJsonPreprocessor.py needs to be fixed to make all testcases run:
embededed -> embedded

@HolQue HolQue requested a review from namsonx August 11, 2025 09:47
@HolQue HolQue requested a review from Copilot August 11, 2025 14:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a typo in the CJsonPreprocessor.py file and activates numerous INLINE_CODE test cases that were previously disabled. The PR enables proper execution of Python inline code tests within the JSON preprocessor.

  • Fixed typo: embedededembedded (as mentioned in description)
  • Activated INLINE_CODE test cases by uncommenting them and updating expected outputs
  • Fixed incorrect variable references in test configuration files

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/testfiles/jpp-test_config_2105.jsonp Comments out problematic inline code expressions
test/testfiles/jpp-test_config_2101.jsonp Fixes variable reference errors (expression → expression1/expression2)
test/testfiles/jpp-test_config_2100.jsonp Removes extra test values to simplify test case
test/testconfig/TestConfig.py Activates inline code tests and updates expected outputs
test/pytest/pytestfiles/test_28_INLINE_CODE_BADCASE.py Adds new test file for inline code bad cases
test/pytest/pytestfiles/test_27_INLINE_CODE_GOODCASE.py Adds new test file for inline code good cases
test/component_test.py Updates version and date
test/JPP_TestUsecases.txt Adds newly activated test case documentation
test/JPP_TestUsecases.rst Adds newly activated test case documentation
test/JPP_TestUsecases.html Adds newly activated test case documentation
test/JPP_TestUsecases.csv Adds newly activated test case documentation
Comments suppressed due to low confidence (1)

test/testfiles/jpp-test_config_2101.jsonp:22

  • The variable name 'expression' is undefined. This should reference 'expression2' based on the context where expression2 is defined on line 21.
    "value4"      : <<${expression2}>>

@namsonx namsonx merged commit e7194ca into namsonx/task/stabi_branch Aug 12, 2025
1 check passed
@test-fullautomation test-fullautomation added enhancement New feature or request 0.14.2 labels Aug 12, 2025
@test-fullautomation test-fullautomation added this to the 0.14.2 milestone Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.14.2 enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

4 participants