Fixed issue automatic adding space in string value. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namsonx
requested review from
HolQue,
milanac030988,
ngoan1608,
test-fullautomation and
trimai3001
| newSubItem = newSubItem + self.__checkAndUpdateKeyValue(subItem) + ", " | ||
| else: | ||
| newSubItem = newSubItem + self.__checkAndUpdateKeyValue(subItem) | ||
| if re.search("\s*\[[^\[\]]*\]\s*,*\s*", item): |
There was a problem hiding this comment.
Hi Son,
can you explain me the code a little.
I would expect that inside a string (means between double quotes) data must be only processed if a ${ sequence exists. Otherwise it mustn't be touched.
Thank you,
Thomas
There was a problem hiding this comment.
Hello Thomas,
This code I handle for the situation that a value (right hand side of ":" in Json config file) is a list and this list contains nested parameters. For example, "key" : [1, "two", ${nested}['abc']['def'], 3, "four"] then the value of nested param will be replaced in this list.
I think I forgot the case that a list value could be separated into multiple lines.
I will update my change tomorrow.
Thank you,
Son
test-fullautomation
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.