Skip to content

SSH key tweaks#15

Merged
hartmantis merged 6 commits intotest-kitchen:masterfrom
hufman:ssh_key_tweaks
Oct 1, 2013
Merged

SSH key tweaks#15
hartmantis merged 6 commits intotest-kitchen:masterfrom
hufman:ssh_key_tweaks

Conversation

@hufman
Copy link
Copy Markdown
Contributor

@hufman hufman commented Sep 9, 2013

The test image I was using does not come with a password, and instead relies on Openstack's keypair support. This code will import a keypair and add it to the image via the Openstack API.

@hartmantis
Copy link
Copy Markdown
Contributor

@hufman Similar to #14, there are a couple style bits the linter doesn't like.

Adding RSA support: awesome; love it (also a little embarrassed about having not thought of that before).

Uploading keys to OpenStack: is this really the role of a TK driver? It feels like something that should already exist there; that it's an error on my part if I'm trying to use a key that isn't there. I'm not strongly tied to that opinion, though... Thoughts?

Double thanks for the two PRs!

@hufman
Copy link
Copy Markdown
Contributor Author

hufman commented Sep 30, 2013

I assumed that the original intent of the code was to upload the SSH key into the server, so I continued that intent when adding support for Openstack key pairs. That code has been clipped out.

@hartmantis hartmantis mentioned this pull request Sep 30, 2013
@hufman
Copy link
Copy Markdown
Contributor Author

hufman commented Sep 30, 2013

And that outright confuses me, I'm doing the exact same server.password call that the later function does D:

hartmantis added a commit that referenced this pull request Oct 1, 2013
@hartmantis hartmantis merged commit 535ce45 into test-kitchen:master Oct 1, 2013
@hufman hufman deleted the ssh_key_tweaks branch October 15, 2013 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants