Dynamically allocate Floating IP for the test server.#155
Merged
jjasghar merged 1 commit intotest-kitchen:masterfrom Feb 27, 2017
Merged
Dynamically allocate Floating IP for the test server.#155jjasghar merged 1 commit intotest-kitchen:masterfrom
jjasghar merged 1 commit intotest-kitchen:masterfrom
Conversation
dannytrigo
force-pushed
the
feature/allocateip
branch
4 times, most recently
from
31be679 to
2220ec9
Compare
1 similar comment
Author
|
So, I took what Fodoj started, and adapted it to add a flag allocate_floating_ip to turn on the new behaviour (defaulting to false). I am not so experienced in ruby/spec testing/rubocop, and didn't quite understand all the rubocop failures/warnings, so I disabled some until it passed, but please feed back if there is a better way. Most were warnings about code that wasn't even touched. |
dannytrigo
force-pushed
the
feature/allocateip
branch
2 times, most recently
from
9ac8264 to
7b070f3
Compare
Author
|
Any advice or things to do to be able to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on the work of Fodoj, but add a new flag to maintain backwards compatibility