Skip to content

Fix creation of floating IP to use network ID instead of name#162

Merged
jjasghar merged 1 commit intotest-kitchen:masterfrom
dannytrigo:feature/allocateip
Mar 27, 2017
Merged

Fix creation of floating IP to use network ID instead of name#162
jjasghar merged 1 commit intotest-kitchen:masterfrom
dannytrigo:feature/allocateip

Conversation

@dannytrigo
Copy link
Copy Markdown

Also fix deletion to ensure its a floating IP we try to delete

@dannytrigo
Copy link
Copy Markdown
Author

dannytrigo commented Mar 15, 2017

The previous changes to allocate and destroy a floating IP do not work well as Fog expects a network ID rather than a name. This should fix it.

Also fix deletion to ensure its a floating IP we try to delete
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 15, 2017

Coverage Status

Coverage increased (+0.02%) to 99.296% when pulling 8a4c2ef on dannytrigo:feature/allocateip into f4646cd on test-kitchen:master.

@dannytrigo
Copy link
Copy Markdown
Author

Tested better this time:

-----> Creating <serverspec-openstack>...
       OpenStack instance with ID of <4bcac94b-44eb-49de-b057-3aea62a65aec> is ready.
       Attaching floating IP from <external> pool
       Created floating IP <1.2.3.4> from <external> pool
       Attaching floating IP <1.2.3.4>
       Waiting for server to be ready...
       Waiting for SSH service on 1.2.3.4:22, retrying in 3 seconds

-----> Destroying <serverspec-openstack>...
       Retrieve the floating IP
       Retrieve the ID of floating IP <1.2.3.4>
       OpenStack Floating IP <1.2.3.4> released.
       OpenStack instance <4bcac94b-44eb-49de-b057-3aea62a65aec> destroyed.
       Finished destroying <serverspec-openstack> (0m20.84s).

@dannytrigo
Copy link
Copy Markdown
Author

Any chance to merge this? The implementation with the new flag is completely broken without it

@jjasghar jjasghar merged commit 54ff77a into test-kitchen:master Mar 27, 2017
@dannytrigo
Copy link
Copy Markdown
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants