Fix creation of floating IP to use network ID instead of name#162
Merged
jjasghar merged 1 commit intotest-kitchen:masterfrom Mar 27, 2017
Merged
Fix creation of floating IP to use network ID instead of name#162jjasghar merged 1 commit intotest-kitchen:masterfrom
jjasghar merged 1 commit intotest-kitchen:masterfrom
Conversation
Author
|
The previous changes to allocate and destroy a floating IP do not work well as Fog expects a network ID rather than a name. This should fix it. |
e0cd848 to
8a4c2ef
Compare
Also fix deletion to ensure its a floating IP we try to delete
Author
|
Tested better this time: |
Author
|
Any chance to merge this? The implementation with the new flag is completely broken without it |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix deletion to ensure its a floating IP we try to delete