Switch from fog to fog-openstack to slim deps and speed runtime#174
Merged
jjasghar merged 2 commits intotest-kitchen:masterfrom Nov 10, 2017
tas50:slim
Merged
Switch from fog to fog-openstack to slim deps and speed runtime#174jjasghar merged 2 commits intotest-kitchen:masterfrom tas50:slim
jjasghar merged 2 commits intotest-kitchen:masterfrom
tas50:slim
Conversation
Signed-off-by: Tim Smith <tsmith@chef.io>
Switch to chefstyle to get the build green and aligned with other chef nurtured projects. Switch from the monolithic fog gem to the fog-openstack gem. This gem loads significantly faster than the monolithic gem and drops us from 114 gem deps to 77, which is pretty cool if you ask me. Signed-off-by: Tim Smith <tsmith@chef.io>
|
Changes Unknown when pulling ba7413a on tas50:slim into ** on test-kitchen:master**. |
2 similar comments
|
Changes Unknown when pulling ba7413a on tas50:slim into ** on test-kitchen:master**. |
|
Changes Unknown when pulling ba7413a on tas50:slim into ** on test-kitchen:master**. |
Member
Author
|
@jjasghar here you go |
|
Any known reason why the merge hasn't been completed? I like the idea of reducing dependencies, when possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the total deps from 114 to 77. It also speed up runtime. I've switched from a failing rubocop setup to chefstyle as well and added testing on Ruby 2.4.1.