Merged
Conversation
2 similar comments
|
Is there anything preventing this from being merged? I'm basically dead in the water when it comes to using this plugin without something like what this PR provides. |
Contributor
|
I need to build a devstack instance to test this before merging. I will attempt to do this ASAP. |
|
Any update? |
Contributor
|
I haven’t had cycled to test this. If someone else has and willing to state here that is works, I’ll merge and release. |
|
This PR works pretty well with identity v3. |
Contributor
|
Awesome! I'll do the release today. thanks for the confirmation @dewdo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi - I modified the plugin to work with identity v3 where the domain_id can be passed in and "tenant" is renamed to "project". Seems to work just fine; I'm provisioning new instances on OpenStack version Pike no problems at all.