Skip to content

added support to assign security groups#37

Merged
hartmantis merged 3 commits intotest-kitchen:masterfrom
bears4barrett:master
Jan 30, 2014
Merged

added support to assign security groups#37
hartmantis merged 3 commits intotest-kitchen:masterfrom
bears4barrett:master

Conversation

@bears4barrett
Copy link
Copy Markdown
Contributor

Resolves this issue:
#36

@hartmantis
Copy link
Copy Markdown
Contributor

Haha; that was fast!

The changes made the build sad, though :( Looks like a couple of style bits Rubocop doesn't like and the change to server_def causing several unit tests to fail. If those can be resolved and a test added for the new functionality, I'll merge this in.

Comment thread lib/kitchen/driver/openstack.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or does it seem a little ridiculous that this has to be handled this way, and that neither the OpenStack API nor Fog complains if you try to create a server with invalid security groups? Weird.

@bears4barrett
Copy link
Copy Markdown
Contributor Author

I updated so security groups is not always in the server definition, only if provided. I also found that fog will catch the issue in the case of a wrongly named security group. The prior check has been removed. Lastly, I added a spec test for security groups.

@hartmantis
Copy link
Copy Markdown
Contributor

Great! Thank you!

hartmantis added a commit that referenced this pull request Jan 30, 2014
added support to assign security groups
@hartmantis hartmantis merged commit cc3e02d into test-kitchen:master Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants