added basic support for networks#39
added basic support for networks#39hartmantis merged 7 commits intotest-kitchen:masterfrom monsterzz:create-server-with-nic-id
Conversation
|
oh, snap. didn't checked existing pull requests :( if you have any tips or issues on existing PRs I can fix them to integrate this feature as soon as possible. Thanks. |
|
Hi, I sent PR #38 😄 "compute.network" in find_network method is correct? for example: To get the list of networks, we need to do as follows? I don't know the fog and openstack well, so I might be wrong. (or I may be mistaken in .kitchen.yml...) |
|
... And can this allow to specify multiple networks ? |
|
damn it. last minute fix :( |
add multiple nics support
|
Just a comment on @tenforward's comment earlier: what we discovered in #33 was that an unknown number of OpenStack environments (including all the ones I have access to for testing) don't run a network service, so calls to Otherwise, looks good to me so far, pending the in-progress edits. |
|
Fixed. Now you can specify one or multiple networks. I don't have openstack installation without network service, so I think it will raise smth like 'service not found' exception. I have mentioned it in docs. I'm not fluent in english, so doc change require some corrections. Please have a look. If you'll be comfortable with squashed version of this PR (one commit), I can squash it in new branch and send new PR. Thanks. |
|
Awesome! With the new changes, this looks good to me. I don't have an OpenStack environment to test the new networking piece in, though. @tenforward, does this look like it will do what you need it to? |
|
Hi! |
|
Great! Thanks for confirming. |
added basic support for networks
Adds
network_refto driver configuration to create instance in desired network.By default, instance will be created in all available networks, and you need to pass
openstack_network_nameto select which one to use in ssh connection. In small OpenStack installations it's okay, but if you have big and company-wide shared installation it's inadmissible to allocate IP address in each available network.