Use floating IP for ssh connection by default if defined or allocated from pool.#46
Merged
hartmantis merged 2 commits intotest-kitchen:masterfrom Apr 9, 2014
Merged
Conversation
Contributor
|
Looks like the change broke one of the unit tests but, if that can be fixed, that sounds logical to me. |
Contributor
Author
|
Ruby n00b forgot that the last line of a method is the return value. Passes unit test now. |
Contributor
|
Great! Thanks a bunch! |
hartmantis
added a commit
that referenced
this pull request
Apr 9, 2014
Use floating IP for ssh connection by default if defined or allocated from pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my opinion, if you go to the trouble of allocating a floating IP, you probably want to use it to connect with SSH. This patch implements that functionality.