Select the first valid IP if all other checks fail#56
Merged
hartmantis merged 2 commits intotest-kitchen:masterfrom Sep 4, 2014
jer:unpredictablenetworks
Merged
Select the first valid IP if all other checks fail#56hartmantis merged 2 commits intotest-kitchen:masterfrom jer:unpredictablenetworks
hartmantis merged 2 commits intotest-kitchen:masterfrom
jer:unpredictablenetworks
Conversation
- If there is no 'public' or 'private' network name, and none has been user-configured, just pick the first ip given by server.ip_addresses. - When the floating_ips extension is forbidden with a 403, treat it the same as a 404 when running get_ip
Contributor
Author
|
Hmmm... I have no idea how to fix that error. Can someone give me some guidance? |
Contributor
|
sigh Good old OpenStack networking. The build error is because Rubocop dropped support for Ruby 1.9.2 anymore. All the others passed, so I'll rip it out of the build matrix and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user-configured, just pick the first ip given by server.ip_addresses.
same as a 404 when running get_ip