Added a check for ssh key authetication#85
Merged
Conversation
added 2 commits
July 16, 2015 16:49
It seems there was a race condition, this method checks for ssh key authentication before continuing the run.
|
Minor rubocop things, nothing I would hold this up for. If remaining functionality still looks good to you, I'm 👍 on the change. :) |
Contributor
Author
|
Grrr rubocop...yeah ill get those fixed here and then run the suite. I'll mark this as WIP. |
jjasghar
changed the title
added 2 commits
July 16, 2015 18:36
Contributor
Author
|
These tests now fail: #create
required options provided
generates a server name in the absence of one (FAILED - 1)
gets a proper server ID (FAILED - 2)
gets a proper hostname (IP) (FAILED - 3)
does not disable SSL validation (FAILED - 4)
SSL validation disabled
disables SSL cert validation (FAILED - 5) |
Closed
jjasghar
changed the title
Contributor
|
@jjasghar any update on this PR? We're running into this causing us a lot of trouble. Let me know if there's anything we can do to help. |
Contributor
Author
|
Wow, this completely fell through the cracks. I'll get this reprioritized. |
Contributor
Author
|
Released via 1.9.0.dev, please test and report issues: #93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems there was a race condition, this method checks for ssh key
authentication before continuing the run.
With the help of @adamleff we were able to get this done.