Skip to content

Fail if required key information can't be found#88

Merged
hartmantis merged 1 commit intomasterfrom
jdh-prep-for-release
Jul 22, 2015
Merged

Fail if required key information can't be found#88
hartmantis merged 1 commit intomasterfrom
jdh-prep-for-release

Conversation

@hartmantis
Copy link
Copy Markdown
Contributor

No description provided.

@hartmantis
Copy link
Copy Markdown
Contributor Author

@jjasghar With the change in #86, this line will always evaluate to true because it's testing whether the symbol :private_key_path exists, rather than whether that key exists in the config hash.

This would, I think, cover the issue the user reported using Kitchen's configuration methods to

  • Fail if no private key path can be found
  • Fail if neither a public key nor a name of a key in OpenStack can be found

Does that sound right? It assumes use of SSH (i.e. won't work with Windows VMs) but that assumption already exists in other places that would need to be reworked to add Windows support.

@jjasghar
Copy link
Copy Markdown
Contributor

👍 yeah that's much better.

hartmantis added a commit that referenced this pull request Jul 22, 2015
Fail if required key information can't be found
@hartmantis hartmantis merged commit de4a0c7 into master Jul 22, 2015
@hartmantis hartmantis deleted the jdh-prep-for-release branch July 22, 2015 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants