perf: HttpConnection write bytes directly into the buffer#100
Merged
HofmeisterAn merged 6 commits intotestcontainers:mainfrom Apr 23, 2026
Merged
perf: HttpConnection write bytes directly into the buffer#100HofmeisterAn merged 6 commits intotestcontainers:mainfrom
HofmeisterAn merged 6 commits intotestcontainers:mainfrom
Conversation
HofmeisterAn
requested changes
Apr 22, 2026
Collaborator
HofmeisterAn
left a comment
There was a problem hiding this comment.
I think the many preprocessor directives make the code hard to read. I propose using proper abstraction (a base class) and separate implementations for the underlying buffer (ArrayBufferWriter and MemoryStream) that handle writing to the buffer. Then we can use a single preprocessor directive to include the class entirely, like we're doing here. Then we don't need if-else in HttpConnection.
Author
|
Do you mean something like this dd4d234? |
Collaborator
See my recent changes, I was thinking of something like this. WDYT? I'll take another look tomorrow, but I think it's easier to read now. |
Author
|
Ah ok. Yes, looks good to me! |
campersau
commented
Apr 23, 2026
HofmeisterAn
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark on net10.0