Skip to content

Conversation

@mt-akar
Copy link

@mt-akar mt-akar commented Mar 27, 2025

As per the the issue on the original repo.

Problem

ContainerInspectParameters.IncludeSize was defined but never used, therefore, there were no way to get SizeRootFs and SizeRw values in the existing InspectContainerAsync operation.

Solution

Created a InspectContainerAsync overload that also accepts ContainerInspectParameters

@mt-akar mt-akar changed the title Created InspectContainerAsync overload passing ContainerInspectParame… Created InspectContainerAsync overload passing Parameters Mar 27, 2025
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Mar 31, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HofmeisterAn HofmeisterAn changed the title Created InspectContainerAsync overload passing Parameters feat: Add query argument for container inspect API: containers/{id}/json Mar 31, 2025
@HofmeisterAn HofmeisterAn merged commit a9ebc1f into testcontainers:main Mar 31, 2025
2 checks passed
@mt-akar
Copy link
Author

mt-akar commented Mar 31, 2025

@HofmeisterAn when would the NuGet be updated? I would like to use it.

@HofmeisterAn
Copy link
Collaborator

I want to merge the other PR and check the stream implementation before we publish a new version. This might take a couple of days.

@mt-akar
Copy link
Author

mt-akar commented Apr 9, 2025

Any luck, @HofmeisterAn? I am waiting for the new version.

@HofmeisterAn
Copy link
Collaborator

I believe we found the root cause of the issue, I can fix it and provide a new version by the end of next week.

@HofmeisterAn
Copy link
Collaborator

@mt-akar I just pushed a new version: 3.127.0. Let me know if you run into any issues, some internal parts handling the stream have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants