Docker-java client is not thread safe

[bsideup]

Hi!

First of all, thanks for this cool project :) Here, at ZeroTurnaround, we created something similar, but will definitely try yours as well :) Even more - you already use our library - zt-exec :)

What we discovered during our work - DockerClient is not thread safe. We heavily recommend to replace SingletonDockerClient with ThreadLocalDockerClient, or client-per-container.

See docker-java/docker-java#339 (comment)

[rnorth]

Hi Sergei,
Thanks for raising this, and thanks for zt-exec - I'm a fan of JRebel too! ;)

I'm wondering if I might have luckily dodged a bullet with my own singleton wrapper but I ought to check again with this thread safety issue in mind. I'm glad to be able to learn from your experiences in this area!

Thank you
Richard

[rnorth]

Ah, I misunderstood your point on first read - yes, this is probably a problem. Using a ThreadLocal seems like a good solution - I'll most likely go that route.
Thanks for this
Richard

[rnorth]

Released in v0.9.9 just now.