Remove hardcoded Oracle image name #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
commented
Mar 29, 2018
| return new OracleContainer(OracleContainer.IMAGE + ":" + tag); | ||
|
|
||
| if (!tag.equalsIgnoreCase("latest")) { | ||
| throw new UnsupportedOperationException("Oracle database tag should be set in the configured image name"); |
Member
Author
There was a problem hiding this comment.
It's a PITA to support setting the tag via the JDBC URL, and it wasn't usable previously anyway. This could be improved, but perhaps only if there is demand.
bsideup
reviewed
Apr 4, 2018
| @@ -0,0 +1 @@ | |||
| oracle.container.image=wnameless/oracle-xe-11g@sha256:15ff9ef50b4f90613c9780b589c57d98a8a9d496decec854316d96396ec5c085 | |||
Member
There was a problem hiding this comment.
this module has Oracle module as a dependency where the property is already set. Doesn't it work?
Member
Author
There was a problem hiding this comment.
Ah no; both of these modules have the properties file in src/test/resources, so that bit of the classpath isn't shared.
bsideup
approved these changes
Apr 4, 2018
Member
Author
|
@kiview do you want to add anything? Otherwise, let's merge 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.