Skip to content

Recompiled with R# SDK 2021.3.0-eap03 and removed explicit DTE dependencies#83

Merged
testcop merged 7 commits intotestcop:masterfrom
rayphi:master
Nov 21, 2021
Merged

Recompiled with R# SDK 2021.3.0-eap03 and removed explicit DTE dependencies#83
testcop merged 7 commits intotestcop:masterfrom
rayphi:master

Conversation

@rayphi
Copy link
Copy Markdown
Contributor

@rayphi rayphi commented Oct 11, 2021

Closes #72

Contains:

  • SDK upgrade to 2021.3.0-eap03
  • removed explicit dte dependencies to potentially provide backwards compatibility
  • there remains the Microsoft.VisualStudio.Interop package which could restore backwards compatibility but this is needed to provide the auto shortcut assignments.

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Oct 12, 2021

I think we need to switch to IEnvDteWrapper like @matkoch is already doing in the resharper-presentation-assistant
project.

but i have to do some research, because i can't find any alternative for DTE.Commands.Item() and DTE.Windows.Item().

@testcop
Copy link
Copy Markdown
Owner

testcop commented Oct 12, 2021

there might be what we need hanging off IEnvDteWrapper
IEnvDteWrapper::IEnvDteToolWindows::OutputWindow

and a dot peek inside of IEnvDteWrapper::IEnvDteCommands might tell us how to add/change a command

@rayphi

This comment has been minimized.

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Oct 15, 2021

https://youtrack.jetbrains.com/issue/RSRP-486460 seems to be fixed in some branch that will hopefully be released in one of the next versions. :)

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Oct 20, 2021

Update: Issue status changed to "Fixed" and availability to "Next EAP 2021.3"

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Oct 25, 2021

Sadly there are still some issues... I'm working on it:

Created another issue over here https://youtrack.jetbrains.com/issue/RSRP-486639

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Oct 27, 2021

And another one over here https://youtrack.jetbrains.com/issue/RSRP-486663 :D

@testcop
Copy link
Copy Markdown
Owner

testcop commented Nov 8, 2021

Hi @rayphi , what is the latest on this? Are we waiting on Jetbrains before we can support multiple versions of Visual Studio?

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Nov 8, 2021

Today the version with the bugfixes came out (EAP7) I'll try tomorrow to see if this solves all our problems.

@ModernRonin
Copy link
Copy Markdown

does your last commit mean that if I pull your branch and build it, I get a local plugin that works under VS2020 with R# EAP7, @rayphi ?

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Nov 11, 2021

@ModernRonin yes there are some bugs on the options page but generally it works fine 😉

@ModernRonin
Copy link
Copy Markdown

you are my hero!

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Nov 17, 2021

@testcop there it is ready to publish 🎉

@testcop
Copy link
Copy Markdown
Owner

testcop commented Nov 19, 2021

@testcop there it is ready to publish 🎉

Done Done ? VS2017 onwards? Awesome...

@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Nov 20, 2021

I've tested only VS2019 and VS2022 but yeah I hope Jetbrains wrappers works also for VS2017

@testcop testcop merged commit f55c9c5 into testcop:master Nov 21, 2021
@rayphi
Copy link
Copy Markdown
Contributor Author

rayphi commented Nov 24, 2021

@testcop when do you plan to release this version?

@testcop
Copy link
Copy Markdown
Owner

testcop commented Nov 29, 2021

released today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R# 2021.2.x Support

3 participants