Correct /han-update-documentation for five-plugin layout, and update all docs#47
Merged
Merged
Conversation
The skill predated the multi-plugin restructure and assumed a single
plugin/ directory (plugin/skills, plugin/agents, one plugin.json at
depth 2). Its prereq markers and Step 2 inventory targeted paths that
no longer exist, so the skill could not run.
Point the prereqs, sweep enumeration, source-of-truth reads, index
consistency check, scope-mapping, and audit-checklist at the real
layout: skills across han.core/han.github/han.reporting/han.feedback,
agents only in han.core/agents, manifests at {plugin}/.claude-plugin/.
- update-pr-description: rename stale 'Test Plan' to 'How this was tested' (the section the SKILL.md actually produces). - iterative-plan-review: document the conditional third companion file artifacts/feature-technical-notes.md (spec-aware mode). - plan-implementation: list artifacts/feature-technical-notes.md as a read/linked source-spec companion alongside decision-log/team-findings. - structural-analyst: add /iterative-plan-review and /plan-implementation to its dispatcher list, matching sibling spine agents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR teaches the
/han-update-documentationskill to audit the four-plugin layout instead of the old single-plugin/layout, so that documentation sweeps actually find every skill and agent now that Han ships as multiple plugins.han.core,han.github,han.reporting,han.feedback) and agents from the one root that has them (han.core), replacing every hardcodedplugin/skillsandplugin/agentspath that no longer exists on disk.findtomaxdepth 3(the manifests now sit one level lower under named plugin folders) and probes each named skill root directly, so the skill no longer silently fails to locate its own inputs.structural-analyst, a third spec-aware artifact (feature-technical-notes.md) documented acrossiterative-plan-reviewandplan-implementation, and section-name fixes inupdate-pr-description.findinvocations and the{plugin}placeholder convention cover exactly the roots that exist, with no root missed and no deadplugin/path left behind.What to look at first
### Plugin rootsblock inSKILL.mdis the central decision: it establishes that{plugin}means one of the four skill roots and that agents live only underhan.core. Every other path edit in the skill and its two reference files inherits this convention, so confirm the four roots named here match the repository layout (han.core,han.github,han.reporting,han.feedback).feature-technical-notes.mddocumentation thread spans three files (iterative-plan-review,plan-implementation, and indirectly the spec-aware flow). Check that the "absence is not a gap" framing is consistent everywhere: the file is created lazily and only when a load-bearing mechanic is captured, and each doc says so the same way.findchange frommaxdepth 2tomaxdepth 3plus the switch to explicitly-named roots (find han.core han.github han.reporting han.feedback ...) is the failure-mode fix. Worth a glance to confirm a missing root degrades gracefully (the2>/dev/nullsuppression) rather than aborting the whole sweep.Files of interest
.claude/skills/han-update-documentation/SKILL.md— the central change: plugin-root discovery, the new### Plugin rootsblock, and updated sweepfindcommands..claude/skills/han-update-documentation/references/audit-checklist.md— rewrites every skill/agent path rule to the{plugin}convention andhan.core/agents..claude/skills/han-update-documentation/references/scope-mapping.md— updates the changed-path-to-entity mapping table and cascade rules to the four-root layout.docs/skills/iterative-plan-review.md— documents the newfeature-technical-notes.mdspec-aware artifact and its lazy-creation semantics.docs/agents/structural-analyst.md— expands the dispatch list to include/iterative-plan-reviewand/plan-implementation.