Skip to content

[FIX] 'invalid_union_discriminator'#57

Merged
josephburgess merged 1 commit intotesterloop:masterfrom
josephburgess:fix-invalid-union-discriminator
May 30, 2023
Merged

[FIX] 'invalid_union_discriminator'#57
josephburgess merged 1 commit intotesterloop:masterfrom
josephburgess:fix-invalid-union-discriminator

Conversation

@josephburgess
Copy link
Copy Markdown
Member

@josephburgess josephburgess commented May 25, 2023

Change:

  • add type: 'object' to ConsoleEvent fileSchema

Possibly an isolated issue but there's a chance for a consoleLog.args item to be type: 'object' . This occurred when not using Orchard VPN so tests failed to fetch internal orchard URLs (see example console-logs.json below)

This adjusts the fileSchema to allow for that scenario and avoids the error being thrown.

Error:
image

console-log.json extract:

"args": [
            {
                "type": "string",
                "value": "Error sending segment performance metrics"
            },
            {
                "type": "object",
                "subtype": "error",
                "className": "TypeError",
                "description": "TypeError: Failed to fetch\n    at C.e (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:196146)\n    at sn (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:72679)\n    at o (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:70948)\n    at o (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:38434)\n    at t.<anonymous> (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29980)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50524\n    at Object.next (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50629)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49545\n    at new Promise (<anonymous>)\n    at s (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49290)\n    at t.send (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29783)\n    at t.<anonymous> (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29656)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50524\n    at Object.next (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50629)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49545\n    at new Promise (<anonymous>)\n    at s (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49290)\n    at t.flush (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29516)\n    at c (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:28903)\n    at r (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:213936)\n    at i (https://documents.qaawal.com/:3:1402)\n    at https://documents.qaawal.com/:3:2172\n    at Array.forEach (<anonymous>)\n    at $Cypress.pause (https://documents.qaawal.com/:3:2089)",
                "objectId": "-7696240739771167428.17.1",
                "preview": {
                    "type": "object",
                    "subtype": "error",
                    "description": "TypeError: Failed to fetch\n    at C.e (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:196146)\n    at sn (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:72679)\n    at o (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:70948)\n    at o (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:38434)\n    at t.<anonymous> (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29980)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50524\n    at Object.next (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50629)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49545\n    at new Promise (<anonymous>)\n    at s (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49290)\n    at t.send (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29783)\n    at t.<anonymous> (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29656)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50524\n    at Object.next (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:50629)\n    at https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49545\n    at new Promise (<anonymous>)\n    at s (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:49290)\n    at t.flush (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:29516)\n    at c (https://cdn.segment.com/analytics.js/v1/XdT1O6w2RpAuXqyR7VOXlLIBGY5v6D31/analytics.min.js:1:28903)\n    at r (https://qa-cdn.theorchard.io/frontend-documents/frontend-documents.vendors.f990c6bcd392cde312c2.js:2:213936)\n    at i (https://documents.qaawal.com/:3:1402)\n    at https://documents.qaawal.com/:3:2172\n    at Array.forEach (<anonymous>)\n    at $Cypress.pause (https://documents.qaawal.com/:3:2089)",
                    "overflow": false,
                    "properties": [
                        {
                            "name": "stack",
                            "type": "string",
                            "value": "TypeError: Failed to fetch\n    at C.e (https://qa-…ress.pause (https://documents.qaawal.com/:3:2089)"
                        },
                        {
                            "name": "message",
                            "type": "string",
                            "value": "Failed to fetch"
                        }
                    ]
                }
            }
        ],

@josephburgess josephburgess requested a review from meiamsome May 25, 2023 16:40
@josephburgess josephburgess changed the title [FIX] 'invalid_union_discriminator' bug [FIX] 'invalid_union_discriminator' May 25, 2023
@meiamsome
Copy link
Copy Markdown
Contributor

Yep, exactly. Just add these as we find examples of them. We should probably add test cases at some point based on the real examples we've seen.

@josephburgess josephburgess merged commit 3e4983e into testerloop:master May 30, 2023
@josephburgess josephburgess deleted the fix-invalid-union-discriminator branch May 30, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants