fix: use deterministic temp dir for history cache storage#29
Merged
Conversation
mkdtempSync creates a unique dir per run, so @actions/cache restores the archive to the old random path while the code checks a different new random path — always a miss, always "First run on this branch". Replace with a fixed path derived from branch + report-path hash so save and restore always use the same location across runs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
History cache was never restored between runs because
mkdtempSyncgenerates a randomdirectory name on every run.
@actions/cachearchives files at their absolute path andrestores them to that same path — so a cache saved from
/tmp/testglance-abc123/cannever be found when the next run looks at
/tmp/testglance-xyz789/. Every run was aguaranteed cache miss, causing "First run on this branch" forever.
Changes
mkdtempSyncwith a deterministic directory path derived frombranch + reportPathHashnode:fsmocks in both test files (mkdtempSync→mkdirSync)Test plan