Skip to content

feat: make api-key optional with local-only default mode#39

Merged
maximn merged 2 commits into
mainfrom
feat/story-9.1-api-key-optional
Apr 9, 2026
Merged

feat: make api-key optional with local-only default mode#39
maximn merged 2 commits into
mainfrom
feat/story-9.1-api-key-optional

Conversation

@maximn
Copy link
Copy Markdown
Contributor

@maximn maximn commented Apr 9, 2026

Summary

  • Make api-key input optional (required: false, default: '') so the action works standalone with zero config
  • When no api-key is provided, enter local-only mode: skip API calls, still produce CI summary, annotations, and PR comments
  • Decouple PR comments from SaaS API success — local-only mode can post PR comments when github-token is available
  • Add 6 unit tests covering local-only mode behavior
  • Add Local-only: no api-key E2E step; remove api-key: unused / send-results: false workaround from all E2E steps

Test plan

  • All 639 unit tests pass (pnpm test)
  • TypeScript compiles cleanly (pnpm typecheck)
  • ESLint passes (pnpm lint)
  • dist/ builds successfully (pnpm build)
  • E2E workflow passes in CI (new Local-only: no api-key step exits 0)

maximn added 2 commits April 9, 2026 19:02
- Change api-key input from required to optional (default: '')
- Detect local-only mode when no api-key provided, force sendResults=false
- Decouple PR comments from SaaS API success for local-only mode
- Add unit tests for local-only mode behavior
- Add local-only E2E step, remove api-key: unused workaround from e2e.yml
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

🔬 TestGlance

✅ test — 100.0% pass rate

████████████████ 100.0%
✅ 639 passed · ⏱️ 2.1s · 🏥 95/100


Signal Details
🔵 6 new test(s) added
🔵 Health Score: 95 → 95

vs main

Metric main PR Delta
Pass rate 100.0% 100.0% +0.0%
Duration 2.1s 2.1s +0.3%

View Run → · 📄 HTML Report


Updated 2026-04-09T18:03:21.345Z

@maximn maximn merged commit 4e78c6c into main Apr 9, 2026
7 checks passed
@maximn maximn deleted the feat/story-9.1-api-key-optional branch April 9, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant