Merged
Conversation
These are part of our public API and should not be removed in a patch release. We do however deprecate them. Signed-off-by: Stephen Finucane <stephen@that.guru>
jelmer
approved these changes
Mar 6, 2026
stephenfin
added a commit
to stephenfin/testtools
that referenced
this pull request
Mar 25, 2026
This was removed from fixtures recently [1]. While it has been re-added [2], the fixture is small enough that we can just vendor it here. Note that this makes fixtures a requirement of the test suite. That seems okay given these tests are no longer packaged. [1] testing-cabal/fixtures#114 [2] testing-cabal/fixtures#122 Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
added a commit
to stephenfin/testtools
that referenced
this pull request
Mar 25, 2026
This was removed from fixtures recently [1]. While it has been re-added [2], the fixture is small enough that we can just vendor it here. A future change will make fixtures a hard requirement of our test suite, since that's trivially doable now that we no longer package our tests. [1] testing-cabal/fixtures#114 [2] testing-cabal/fixtures#122 Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
added a commit
to stephenfin/testtools
that referenced
this pull request
Mar 26, 2026
This was removed from fixtures recently [1]. While it has been re-added [2], the fixture is small enough that we can just vendor it here. A future change will make fixtures a hard requirement of our test suite, since that's trivially doable now that we no longer package our tests. [1] testing-cabal/fixtures#114 [2] testing-cabal/fixtures#122 Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
added a commit
to stephenfin/testtools
that referenced
this pull request
Mar 26, 2026
This was removed from fixtures recently [1]. While it has been re-added [2], the fixture is small enough that we can just vendor it here. A future change will make fixtures a hard requirement of our test suite, since that's trivially doable now that we no longer package our tests. [1] testing-cabal/fixtures#114 [2] testing-cabal/fixtures#122 Signed-off-by: Stephen Finucane <stephen@that.guru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with testing-cabal/testtools#566, we should not have dropped these in a patch release and are seeing breakages in related projects. There's zero cost to keeping these around for a while longer so do just that.
This change is