Skip to content

Add Loggable to accepted options of commands since it works at runtime #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Add Loggable to accepted options of commands since it works at runtime #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ import {
SelectorMatcherOptions as DTLSelectorMatcherOptions,
} from '@testing-library/dom'

export interface CTLMatcherOptions {
timeout?: number
export interface CTLMatcherOptions
extends Partial<Cypress.Timeoutable>,
Partial<Cypress.Loggable> {
container?: Element | JQuery<Element>
}

Expand Down Expand Up @@ -223,7 +224,10 @@ declare global {
* @see https://github.com/testing-library/cypress-testing-library#usage
* @see https://github.com/testing-library/dom-testing-library#table-of-contents
*/
findAllByRole(id: ByRoleMatcher, options?: ByRoleOptions): Chainable<JQuery>
findAllByRole(
id: ByRoleMatcher,
options?: ByRoleOptions,
): Chainable<JQuery>

/**
* dom-testing-library helpers for Cypress
Expand Down