Skip to content

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Apr 1, 2021

What:

Add log?: boolean to the options of all commands.

Why:

This is already supported at runtime:

const defaults = {
timeout: Cypress.config().defaultCommandTimeout,
log: true,
}
const options =
typeof lastArg === 'object' ? {...defaults, ...lastArg} : defaults

How:

Just edited the correct .d.ts and checked this change in my project.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Copy link
Contributor

@NicholasBoll NicholasBoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NicholasBoll NicholasBoll merged commit 9e480fa into testing-library:main Jun 2, 2021
@NicholasBoll
Copy link
Contributor

@all-contributors please add @Andarist for code :)

@allcontributors
Copy link
Contributor

@NicholasBoll

I've put up a pull request to add @Andarist! 🎉

@github-actions
Copy link

🎉 This PR is included in version 7.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants