Add support for asymmetric matcher types #715
Open
+27
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The following matchers currently force casts on their arguments, even though they shouldn’t:
Why
Casts add noise to otherwise valid expectations. Asymmetric matchers are a native feature in all supported test frameworks, so they shouldn’t require workarounds.
How
This PR widens the argument types from
unknowntoany, allowing asymmetric matcher values to be passed directly:Checklist