Skip to content

Conversation

@Bitshifter-9
Copy link

eplaced an inefficient forEach loop with the find() method in the
render()
function's container lookup logic, enabling early exit when a matching container is found.

Type of Change
Bug fix (performance optimization)
New feature
Breaking change
Documentation update
The Problem
In
src/pure.js
lines 286-293, when reusing an existing container, the code used forEach to search through mountedRootEntries:

javascript
mountedRootEntries.forEach(rootEntry => {
if (rootEntry.container === container) {
root = rootEntry.root
}
})
The forEach method continues iterating through all entries even after finding the matching container. This is inefficient because:

It performs unnecessary iterations after the match is found
Performance degrades as more containers are mounted
The code doesn't communicate the intent to find a single entry
The Solution
Replaced forEach with the find() method which stops iteration immediately upon finding a match:
#1430

javascript
const rootEntry = mountedRootEntries.find(
rootEntry => rootEntry.container === container,
)
if (rootEntry) {
root = rootEntry.root
}
This change:

⚡ Stops searching immediately when a match is found (early exit optimization)
📈 Improves performance, especially with multiple mounted containers
🎯 Makes the code intent clearer - we're looking for one specific entry
✅ Uses a more idiomatic JavaScript pattern

Replace forEach with find() in render() function's container lookup
logic to enable early exit when a matching container is found.

The previous implementation used forEach which continues iterating
through all entries even after finding the match. This change uses
find() which stops immediately upon finding a match, improving
performance especially when multiple containers are mounted.

- Improves performance with early exit optimization
- More idiomatic JavaScript pattern
- Maintains identical behavior and test coverage
- All 247 tests pass successfully
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 2, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9add965:

Sandbox Source
react-testing-library-examples Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant