Improving intro clarity #1086
Merged
Improving intro clarity #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several engineers at our company have had trouble understanding what the v14 upgrade entailed for us. Having gone through it, it's simple enough, but these changes attempt to clarify things by a) improving grammar b) clarifying a few key points and examples
ph-fritsche
reviewed
Jun 10, 2022
Adopting CR suggestion Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Attempting to address CR comment
timdeschryver
approved these changes
Jun 11, 2022
alexkrolick
reviewed
Jun 13, 2022
Accepting CR suggestion Co-authored-by: Alex Krolick <alexkrolick@users.noreply.github.com>
alexkrolick
reviewed
Jun 13, 2022
eps1lon
reviewed
Jun 14, 2022
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
alexkrolick
reviewed
Jun 14, 2022
ph-fritsche
approved these changes
Jun 20, 2022
alexkrolick
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several engineers at our company have had trouble understanding what the v14 upgrade entailed for us, after just looking at the intro. Having now actually done it, it's simple enough, but these changes attempt to clarify things in the intro by
a) improving grammar
b) clarifying a few key points and examples
c) providing a direct link to the v14 changelog