Skip to content

fix(pointer): support nested select #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2022
Merged

fix(pointer): support nested select #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04d35b
fix(pointer): support nested select
Mar 30, 2022
05c11aa
Merge branch 'main' into pr/select-call-stack
ph-fritsche Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/event/behavior/click.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {dispatchEvent} from '../dispatchEvent'
import {behavior} from './registry'

behavior.click = (event, target, config) => {
const context = target.closest('button,input,label,textarea')
const context = target.closest('button,input,label,select,textarea')
const control = context && isElementType(context, 'label') && context.control
if (control) {
return () => {
Expand Down
8 changes: 8 additions & 0 deletions tests/pointer/click.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,14 @@ describe('label', () => {

expect(getEvents('click')).toHaveLength(2)
})

test('click nested select per label', async () => {
const {element, getEvents, user} = setup(`<label><select/></label>`)

await user.pointer({keys: '[MouseLeft]', target: element})

expect(getEvents('click')).toHaveLength(2)
})
})

describe('check/uncheck control per click', () => {
Expand Down