Skip to content

add prefix to state query params #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MykolaGolubyev merged 2 commits into from
Feb 18, 2019
Merged

add prefix to state query params #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea0707
add prefix to state query params
MykolaGolubyev Feb 18, 2019
0015ef1
update tests
MykolaGolubyev Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/viewer/ComponentViewerStateCreator.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('ComponentViewerStateCreator', () => {

it('should take fullscreen state from url', () => {
const stateCreator = new ComponentViewerStateCreator(registries);
const state = stateCreator.stateFromUrl('fullScreen=true');
const state = stateCreator.stateFromUrl('_rcv_fs=true');

expect(state.isFullScreen).toEqual(true);
});
Expand All @@ -53,6 +53,6 @@ describe('ComponentViewerStateCreator', () => {
selectedToolbarItem: ''
});

expect(url).toEqual('registryName=core&demoName=demo-name&fullScreen=true');
expect(url).toEqual('_rcv_rname=core&_rcv_dname=demo-name&_rcv_fs=true');
});
});
12 changes: 6 additions & 6 deletions src/components/viewer/ComponentViewerStateCreator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import { Registry, Registries } from '../';
import { DemoEntryAndRegistry } from '../registry/DemoEntryAndRegistry';

const queryParamNames = {
registryName: 'registryName',
demoName: 'demoName',
entryTitle: 'entryTitle',
selectedToolbarItem: 'toolbarItem',
isFullScreen: 'fullScreen',
isHelpOn: 'help'
registryName: '_rcv_rname',
demoName: '_rcv_dname',
entryTitle: '_rcv_title',
selectedToolbarItem: '_rcv_titem',
isFullScreen: '_rcv_fs',
isHelpOn: '_rcv_help'
};

export class ComponentViewerStateCreator {
Expand Down