Skip to content

Comments

disable Testomat pipe if 403 status received#697

Merged
DavertMik merged 2 commits into2.xfrom
feat/disable-report-on-403
Feb 16, 2026
Merged

disable Testomat pipe if 403 status received#697
DavertMik merged 2 commits into2.xfrom
feat/disable-report-on-403

Conversation

@AenEnlil
Copy link
Contributor

@AenEnlil AenEnlil commented Feb 11, 2026

User description

Stop reporting to Testomat if 403 status returned


CodeAnt-AI Description

Stop reporting to Testomat when the server returns 403 Forbidden

What Changed

  • When Testomat responds with HTTP 403, reporting is disabled so no further report requests are sent
  • Periodic/reporting background work is stopped and any queued tests for reporting are cleared to prevent repeated failures
  • Existing error messages are preserved so users still see why reporting was skipped

Impact

✅ Fewer failed report attempts
✅ Shorter stuck runs when reporting is blocked
✅ Clearer handling when Testomat API key is invalid or access is forbidden

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai
Copy link

codeant-ai bot commented Feb 11, 2026

CodeAnt AI is reviewing your PR.

@AenEnlil AenEnlil requested a review from DavertMik February 11, 2026 16:49
@AenEnlil AenEnlil changed the title disable Testomat pipe if 403 disable Testomat pipe if 403 status recieved Feb 11, 2026
@codeant-ai codeant-ai bot added the size:S This PR changes 10-29 lines, ignoring generated files label Feb 11, 2026
@codeant-ai
Copy link

codeant-ai bot commented Feb 11, 2026

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review

  • Continue after 403
    Catch blocks call this.#disablePipe() on a 403 response but then continue executing the rest of the handler (incrementing requestFailures, notReportedTestsCount, logging, calling printCreateIssue()). After disabling the pipe you should short-circuit the catch handler to avoid further side effects and extra logs/metrics.

  • In-flight requests not aborted
    Disabling the pipe does not abort ongoing requests or cancel gaxios retries. Pending requests may still complete/ retry after #disablePipe() which may be unexpected. Consider aborting in-flight requests (AbortController) or disabling retries when the pipe is disabled.

  • Silent disable
    #disablePipe() currently disables the pipe and clears the batch but does not emit a clear user-facing warning explaining why reporting was disabled (403). Add a clear console.warn/log with context (status code, suggestion to check API key) so users understand why reporting stops.

@codeant-ai
Copy link

codeant-ai bot commented Feb 11, 2026

CodeAnt AI finished reviewing your PR.

@AenEnlil AenEnlil changed the title disable Testomat pipe if 403 status recieved disable Testomat pipe if 403 status received Feb 13, 2026
@DavertMik DavertMik merged commit 25d68e3 into 2.x Feb 16, 2026
8 checks passed
@DavertMik DavertMik deleted the feat/disable-report-on-403 branch February 16, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants