Skip to content

fix: Prevent exam access in split-screen mode#1023

Merged
Gowreesh-A-M merged 1 commit intomasterfrom
fix/splitscreen-on-exams
Dec 10, 2025
Merged

fix: Prevent exam access in split-screen mode#1023
Gowreesh-A-M merged 1 commit intomasterfrom
fix/splitscreen-on-exams

Conversation

@Gowreesh-A-M
Copy link
Copy Markdown
Contributor

  • Detect when the app enters multi-window mode and treat it as a violation.
  • Preserve violation count across configuration changes to ensure consistent behavior.
  • Display a non-dismissible warning dialog whenever split-screen usage is detected.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @Gowreesh-A-M, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces robust measures to prevent exam access in split-screen mode, enhancing the integrity of the examination process. It implements detection for multi-window usage, maintains a persistent violation count across device configuration changes, and presents a mandatory warning dialog to users, ensuring that exams cannot be conducted while the application is in a split-screen state.

Highlights

  • Multi-Window Mode Detection: The application now actively detects when it enters multi-window (split-screen) mode, treating this as a violation during an exam.
  • Violation Count Persistence: The count of violations is now preserved across configuration changes (e.g., screen rotation), ensuring consistent tracking throughout the exam.
  • Non-Dismissible Warning Dialog: A warning dialog is displayed when split-screen usage is detected. This dialog is non-dismissible while the app remains in multi-window mode, preventing users from continuing the exam until the violation is resolved.
  • Android Manifest Updates: The TestActivity in AndroidManifest.xml has been updated to handle smallestScreenSize and screenLayout configuration changes, allowing the activity to manage its own state during multi-window transitions.
  • Activity Lifecycle Integration: The onMultiWindowModeChanged callback has been implemented in TestActivity and TestFragment to respond to changes in multi-window state, triggering violation logic and UI updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to prevent exam access in split-screen mode by treating it as a violation. The approach is generally sound, involving detection of multi-window mode, preserving violation counts, and showing a non-dismissible dialog. However, I've identified a critical issue where the multi-window mode change event is not propagated from the TestActivity to the TestFragment, rendering the feature non-functional. Additionally, there's a high-severity bug in the onStop logic within TestFragment that fails to record a violation when the app is backgrounded from an existing split-screen session. I have provided code suggestions to address both of these issues.

@Gowreesh-A-M Gowreesh-A-M force-pushed the fix/splitscreen-on-exams branch from 2eb4411 to 7551a55 Compare December 9, 2025 14:51
@Gowreesh-A-M Gowreesh-A-M merged commit 305bf84 into master Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants