fix: Fix initial video stretching by forcing measurement updates#47
fix: Fix initial video stretching by forcing measurement updates#47
Conversation
Summary of ChangesHello @syed-tp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where videos in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where videos would initially appear stretched in React Native on Android. The fix involves overriding requestLayout in TPStreamsRNPlayerView to manually trigger a measure and layout pass, forcing the underlying AspectRatioFrameLayout to update correctly. The approach is sound and directly targets the described problem. My review includes a couple of suggestions to improve the implementation's performance robustness and long-term maintainability.
requestLayoutto manually post a measurement pass, ensures the player bypasses the layout suppression that was causing the video to remain stretched until a major UI event (like a fullscreen toggle) occurred. This guarantees the correct aspect ratio is preserved from the very first frame of playback.