Skip to content

fix: Fix initial video stretching by forcing measurement updates#47

Merged
syed-tp merged 2 commits intomainfrom
fix/layout-issue
Jan 8, 2026
Merged

fix: Fix initial video stretching by forcing measurement updates#47
syed-tp merged 2 commits intomainfrom
fix/layout-issue

Conversation

@syed-tp
Copy link
Copy Markdown
Contributor

@syed-tp syed-tp commented Jan 8, 2026

  • React Native's layout system optimizes by suppressing measurement updates for native views that have static dimensions defined in their styles. This optimization conflicts with the Media3 PlayerView's internal AspectRatioFrameLayout, which relies on granular layout requests to correctly calculate and apply letterboxing/pillarboxing once video dimensions are detected from the stream.
  • This change overrides requestLayout to manually post a measurement pass, ensures the player bypasses the layout suppression that was causing the video to remain stretched until a major UI event (like a fullscreen toggle) occurred. This guarantees the correct aspect ratio is preserved from the very first frame of playback.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @syed-tp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where videos in the TPStreamsRNPlayerView would initially appear stretched due to React Native's layout optimizations preventing timely measurement updates. By explicitly forcing a layout pass, the change ensures that the video player correctly calculates and applies its aspect ratio from the start, providing a consistent viewing experience.

Highlights

  • Addressing React Native Layout Optimization: React Native's layout system optimizes by suppressing measurement updates for native views with static dimensions, which conflicts with Media3 PlayerView's internal AspectRatioFrameLayout.
  • Forcing Measurement Updates: The requestLayout method in TPStreamsRNPlayerView is now overridden to manually post a measurement pass, ensuring the player bypasses the layout suppression.
  • Preserving Video Aspect Ratio: This change guarantees that the correct video aspect ratio is preserved from the very first frame of playback, preventing initial video stretching.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where videos would initially appear stretched in React Native on Android. The fix involves overriding requestLayout in TPStreamsRNPlayerView to manually trigger a measure and layout pass, forcing the underlying AspectRatioFrameLayout to update correctly. The approach is sound and directly targets the described problem. My review includes a couple of suggestions to improve the implementation's performance robustness and long-term maintainability.

Comment thread android/src/main/java/com/tpstreams/TPStreamsRNPlayerView.kt
Comment thread android/src/main/java/com/tpstreams/TPStreamsRNPlayerView.kt Outdated
@syed-tp syed-tp merged commit bc0ab05 into main Jan 8, 2026
7 checks passed
@syed-tp syed-tp deleted the fix/layout-issue branch January 8, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant