Skip to content

Hard coded 60s pause every 2 requests#39

Closed
gerwaric wants to merge 1 commit intotestpushpleaseignore:masterfrom
gerwaric:use-a-slow-fixed-rate-request-limit
Closed

Hard coded 60s pause every 2 requests#39
gerwaric wants to merge 1 commit intotestpushpleaseignore:masterfrom
gerwaric:use-a-slow-fixed-rate-request-limit

Conversation

@gerwaric
Copy link

@gerwaric gerwaric commented Aug 8, 2023

Since the dynamic approach to rate-limiting based on the HTTP headers is buggy, here's a simpler approach that uses the prior framework to hard-code a 60 pause after every 2 requests. This should keep Acquisition under the most restrictive of GGG's current policies, which I think is 100 requests per 1800 seconds.

@Akymo
Copy link

Akymo commented Aug 26, 2023

is this updated with latest version ?

@gerwaric
Copy link
Author

gerwaric commented Aug 26, 2023

is this updated with latest version ?

No, I think the latest current release is still broken, so you’d need to go back to an earlier one.

I was never able to replicate the errors other people had with the new way of handling rate limits, unfortunately, and I’m also going to be offline for burning man for the next couple weeks, so this might not be fixed for a bit.

I can check back in September to so where things are at and maybe take second crack at trying to improve the rate limiting.

@Akymo
Copy link

Akymo commented Aug 28, 2023

is there any version at all that works now? or how i can get it to work?

@gerwaric
Copy link
Author

I don't think there is, sorry. At this point, I need someone to help me debug the problem with the rate-limiting approach I coded a couple weeks ago. It works great for me, but I believe it's still broken for everyone else who has tried it, and I've been unable to replicate those errors.

@Akymo
Copy link

Akymo commented Sep 15, 2023

add me on discord Azuwi ill help you debug it

@gerwaric
Copy link
Author

Thank you, that would be fantastic. Look for a friend request; my discord username begins with a g, and I just sent one.

@gerwaric
Copy link
Author

I'm back at work on my original dynamic rate limiting. My first implementation broke for people outside the US where their computer was set to a non-English language. This time someone from the EU who experienced that bug is helping me, and we have already gotten past that first bug. I'm going to close this pull request now.

@gerwaric gerwaric closed this Sep 25, 2023
@gerwaric gerwaric deleted the use-a-slow-fixed-rate-request-limit branch October 7, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants